Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Nacos is not working properly in DOMAIN mode #4583

Closed
lexburner opened this issue Dec 26, 2020 · 0 comments · Fixed by #4584
Closed

Nacos is not working properly in DOMAIN mode #4583

lexburner opened this issue Dec 26, 2020 · 0 comments · Fixed by #4584
Labels
kind/bug Category issues or prs related to bug.
Milestone
1.4.1

Comments

@lexburner
Copy link
Contributor

lexburner commented Dec 26, 2020 •
edited

Describe the bug
nacos-client should retry when nacos-server runs in cluster mode, but after configuring the domain name for nacos-server, nacos will think it has only one address and will not retry again.

Expected behavior
nacos-client should retry more than one time when configuring the domain name for nacos-server.

nacos should support retry times configuration item for developers because only the developers themselves know the most suitable retry times.

Acutally behavior

only invoke one time when a domain address is configured, nacos-client will not retry when exception occurs.

version: all

image

from above picture, nacos should retry n times.
@lexburner lexburner changed the title Nacos isNot working properly Nacos is not working properly in DOMAIN mode Dec 26, 2020
@lexburner lexburner mentioned this issue Dec 26, 2020
Merged
@KomachiSion KomachiSion added the kind/bug Category issues or prs related to bug. label Dec 27, 2020
@KomachiSion KomachiSion added this to the 1.4.1 milestone Dec 27, 2020
KomachiSion pushed a commit that referenced this issue Dec 28, 2020
@lexburner
[ISSUE #4583] Fix DOMAIN mode retry logic (#4584)
5236287 
* fix namingProxy domain retry logic; add retry param namingRequestDomainMaxRetryCount

* add maxRetry param
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/bug Category issues or prs related to bug.
Projects
None yet
Milestone
1.4.1
Development

Successfully merging a pull request may close this issue.

[ISSUE #4583] Fix DOMAIN mode retry logic lexburner/nacos
2 participants
@lexburner @KomachiSion