Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

using PaginationHelper in cluster mode will be abnormal #4333

Closed
Maijh97 opened this issue Nov 25, 2020 · 0 comments · Fixed by #4334
Closed

using PaginationHelper in cluster mode will be abnormal #4333

Maijh97 opened this issue Nov 25, 2020 · 0 comments · Fixed by #4334
Assignees
Labels
area/Config kind/bug Category issues or prs related to bug.
Milestone

Comments

@Maijh97
Copy link
Collaborator

Maijh97 commented Nov 25, 2020

Describe the bug

If the implemented RowMapper is not in the RowMapperManager, using PaginationHelper in cluster mode will be abnormal.

In some cases, the required mapping field does not correspond to the entity, and a MapRowMapper implementation should be provided to solve this problem.

Expected behavior
A clear and concise description of what you expected to happen.

Acutally behavior
A clear and concise description of what you actually to happen.

How to Reproduce
Steps to reproduce the behavior:

  1. Go to '...'
  2. Click on '....'
  3. Scroll down to '....'
  4. See error

Desktop (please complete the following information):

  • OS: MAC os
  • Version nacos-server 1.4.1
  • Module config
  • SDK original

Additional context
Add any other context about the problem here.

@Maijh97 Maijh97 self-assigned this Nov 25, 2020
@Maijh97 Maijh97 added kind/bug Category issues or prs related to bug. area/Config labels Nov 25, 2020
@Maijh97 Maijh97 added this to the 1.4.1 milestone Nov 25, 2020
chuntaojun pushed a commit that referenced this issue Nov 27, 2020
* for #4311,Fixed Derby data source related SQL LIMIT exception.

* Revert "for #4311,Fixed Derby data source related SQL LIMIT exception."

This reverts commit 49188f1

* fix #4333.

* Remove case conversion.
KomachiSion added a commit that referenced this issue Dec 3, 2020
* [ISSUE-#4262] Fix public namespace permission problem (#4273)

* fix public namespace permission problem

* move NamespaceUtilTest to common module

* [ISSUE-#4232] Use EnvUtil to replace ApplicationUtils about env operation (#4281)

* use EnvUtil to replace ApplicationUtils about env operation

* remove unuse import

* remove unuse import

* remove profile usage

* [ISSUE-#4294] Use EnvUtils.setEnvironment to replace ApplicationUtils.injectEnvironment (#4295)

* use EnvUtils.setEnvironment to replace ApplicationUtils.injectEnvironment.

* remove unuseful import

* remove unuseful import

* refactor: refactor issue #4291 (#4292)

* remove env operation code in ApplicationUtils (#4298)

* refactor issue #4275 (#4299)

* when auth open, use resource parser cache, not use reflect newInstance every time. (#4287)

* [ISSUE-#4256] Just inject environment in StartingSpringApplicationRunListener (#4257)

* just inject environment in StartingSpringApplicationRunListener

* make nacosStartingListener is decoupling with springApplicationRunListener.

* add api doc

* refactor. transfer nacos listeners to SpringApplicationRunListener.

* remove unuseful import

* add doc info

* [ISSUE #4311] Fix Derby data source related SQL LIMIT exception (#4313)

* for #4311,Fixed Derby data source related SQL LIMIT exception.

* fix code style.

* code format.

* [ISSUE-#4310] Delete the main function only for testing (#4312)

* [ISSUE #4320] Fixing the Naming consistency module could not start in cluster mode (#4321)

* refactor: refactor issue #4291

* fix: fixing the Naming consistency module could not start in cluster mode

* fix service list can not search by groupName only (#4308)

* fix service list can not search by groupName only

* fix service list can not search by groupName only

* fix checkStyle

* add ut for NamingUtils

* [ISSUE-#4258]  Fix wrong path when -Dspring.config.location not set (#4259)

* fix spring.config.location is nullapplication.properties when -Dspring.config.location is not set in env

* fix wrong path when -Dspring.config.location not set

* modify default file resource method name

* fix "/" magic value

* change the way of get file

* not judge pathSplit by self, use Paths.get(a, b);

* when spring.config.location is not set, use {nacos.home}/conf/application.properties to cover it.

* refactor code

* code quality enhance

* just use two level to load conf. {spring.config.location}/application.properties -> classpath:/application.properties

* code clean

* Upgrade jraft to 1.3.5 (#4339)

* 升级jraft到1.3.5以支持IPv6, 调整 NamingUtilsTest 代码格式以解决checkstyle问题

* 删除测试类的类注释

* [ISSUE-#4342] Fix nacos.core.protocol.raft.data.read_index_type isn't effect (#4343)

* fix nacos.core.protocol.raft.data.read_index_type=ReadOnlyLeaseBased isn't effect and enhance log hint

* define ReadOnlyOption param name just by self

* [ISSUE-#4333]Add MapRowMapper to RowMapperManager (#4334)

* for #4311,Fixed Derby data source related SQL LIMIT exception.

* Revert "for #4311,Fixed Derby data source related SQL LIMIT exception."

This reverts commit 49188f1

* fix #4333.

* Remove case conversion.

* [ISSUE-#4181]  Normalize ContextPath value in client-side (#4326)

* [ISSUE-#4181] Just use ContextPathUtil normalize ContextPath value

* [ISSUE-#4181] add some test cases

* fix styles at the button '新建命名空间' (#4362)

* [ISSUE-#4346] Fix import code (#4347)

* remove import.*

* transfer first_pre to final static variable

* use NamingBase.Xxx to replace constant

* reuse cliClientService (#4375)

* Sync code from upstream/develop

Co-authored-by: 赵延 <1060026287@qq.com>
Co-authored-by: liaochuntao <liaochuntao@live.com>
Co-authored-by: zhuhao <yczhuhaogg@gmail.com>
Co-authored-by: mai.jh <maijh97@gmail.com>
Co-authored-by: 孙继峰 <sun.jifeng@outlook.com>
Co-authored-by: Mark4z <36187602+mark4z@users.noreply.github.com>
Co-authored-by: 邪影oO <213539@qq.com>
Co-authored-by: Gagharv <wwfortunate@gmail.com>
Co-authored-by: iochenlei <iochenlei@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/Config kind/bug Category issues or prs related to bug.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant