You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Is your feature request related to a problem? Please describe.
When nacos-server fails to start, the http client should be shut down to release related resources.
Describe the solution you'd like
Add the shutdown all http client method in HttpClientBeanHolder.
Call HttpClientBeanHolder#shutdown in the StartingSpringApplicationRunListener#failed method to shut down all http clients.
Describe alternatives you've considered
Additional context
The text was updated successfully, but these errors were encountered:
Considering that when the server fails to start, it usually stops the current service and restarts it. Currently, the http client uses ThreadUtils#addShutdownHook to close, so there is no need to add the http client shutdown method in StartingSpringApplicationRunListener#failed.
Is your feature request related to a problem? Please describe.
When nacos-server fails to start, the http client should be shut down to release related resources.
Describe the solution you'd like
Add the
shutdown
all http client method inHttpClientBeanHolder
.Call
HttpClientBeanHolder#shutdown
in theStartingSpringApplicationRunListener#failed
method to shut down all http clients.Describe alternatives you've considered
Additional context
The text was updated successfully, but these errors were encountered: